Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Ruby 3.2.3 #886

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump to Ruby 3.2.3 #886

wants to merge 1 commit into from

Conversation

huwd
Copy link
Member

@huwd huwd commented Apr 22, 2024

Note ruby v3.0.0 is currently out but there's been some reported problems running it within Apple Silicone due to some changes at the C library level.

For now doing a cautious upgrade until we've confirmed we're unblocked on the mac / docker / ruby combo.

See: govuk-one-login/tech-docs#165

Note ruby v3.0.0 is currently out but there's been some reported
problems running it within Apple Silicone due to some changes at the C
library level.

For now doing a cautious upgrade until we've confirmed we're unblocked
on the mac / docker / ruby combo.

See: govuk-one-login/tech-docs#165
@lfdebrux
Copy link
Member

lfdebrux commented Apr 23, 2024

I tested bundle exec middleman server with this branch on my machine, it worked but I did see this error:

~/.rbenv/versions/3.2.3/lib/ruby/gems/3.2.0/gems/tilt-2.0.11/lib/tilt/redcarpet.rb:64: warning: undefining the allocator of T_DATA class Redcarpet::Markdown

This appears to be a known and fixed issue with RedCarpet and Ruby 3.2 https://www.redmine.org/issues/38118, it might be worth also bumping RedCarpet in this PR?

@huwd
Copy link
Member Author

huwd commented Apr 23, 2024

huh, let me check if I can reproduce.
I'd thought as build and test went OK we were safe 🤔

No good if this blows up the local dev solution too

@huwd
Copy link
Member Author

huwd commented Apr 23, 2024

redcarpet is a dependency within the govuk_tech_docs 😭 really have to do an update over there at some point soon...

🤔 we could try and force it in the gemfile.lock... will take a look but not sure that's right vs trying to update it at source?

@huwd
Copy link
Member Author

huwd commented Apr 23, 2024

I wonder if the time has come to bite the bullet over here...
alphagov/tech-docs-gem#348

Might do a round of dep updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants