Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ckan 2.10.3 #1662

Open
wants to merge 70 commits into
base: main
Choose a base branch
from
Open

Upgrade to ckan 2.10.3 #1662

wants to merge 70 commits into from

Conversation

kentsanggds
Copy link
Contributor

@kentsanggds kentsanggds commented Mar 21, 2024

Upgrade of the datagovuk extension to work with ckan 2.10.3 so that the csw endpoint will work on the same CKAN version.

A number of other features also had to be updated despite it only being a minor upgrade from 2.9 to 2.10, so to accomodate this the tests had to be moved under ckannext/datagovuk.

Also included are improvements to github actions so that solr and pycsw images are only built when they are needed, not each time there is an update.

@kentsanggds kentsanggds force-pushed the upgrade-ckan-2.10.3-tests branch 10 times, most recently from df698ff to d57172c Compare March 26, 2024 16:45
@kentsanggds kentsanggds marked this pull request as ready for review March 26, 2024 16:58
.gitignore Outdated Show resolved Hide resolved
Comment on lines +34 to +38
pip install $pipopt -U factory-boy==3.3.0 mock==2.0.0 pytest==7.4.3 && \

# need to pin pyyaml to correctly pick up config settings
# pip install $pipopt -U pyyaml==5.4
pip install $pipopt -U pyyaml==6.0.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could condense this too:

Suggested change
pip install $pipopt -U factory-boy==3.3.0 mock==2.0.0 pytest==7.4.3 && \
# need to pin pyyaml to correctly pick up config settings
# pip install $pipopt -U pyyaml==5.4
pip install $pipopt -U pyyaml==6.0.1
pip install $pipopt -U factory-boy==3.3.0 mock==2.0.0 pytest==7.4.3 pyyaml==6.0.1

docker/create-pr.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants