New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ckan 2.10.3 #1662
Open
kentsanggds
wants to merge
70
commits into
main
Choose a base branch
from
upgrade-ckan-2.10.3-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade to ckan 2.10.3 #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentsanggds
force-pushed
the
upgrade-ckan-2.10.3-tests
branch
10 times, most recently
from
March 26, 2024 16:45
df698ff
to
d57172c
Compare
Comment on lines
+34
to
+38
pip install $pipopt -U factory-boy==3.3.0 mock==2.0.0 pytest==7.4.3 && \ | ||
|
||
# need to pin pyyaml to correctly pick up config settings | ||
# pip install $pipopt -U pyyaml==5.4 | ||
pip install $pipopt -U pyyaml==6.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could condense this too:
Suggested change
pip install $pipopt -U factory-boy==3.3.0 mock==2.0.0 pytest==7.4.3 && \ | |
# need to pin pyyaml to correctly pick up config settings | |
# pip install $pipopt -U pyyaml==5.4 | |
pip install $pipopt -U pyyaml==6.0.1 | |
pip install $pipopt -U factory-boy==3.3.0 mock==2.0.0 pytest==7.4.3 pyyaml==6.0.1 |
Solr and Pycsw will be manually built
kentsanggds
force-pushed
the
upgrade-ckan-2.10.3-tests
branch
from
April 23, 2024 13:48
698158d
to
7048223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade of the datagovuk extension to work with ckan 2.10.3 so that the csw endpoint will work on the same CKAN version.
A number of other features also had to be updated despite it only being a minor upgrade from 2.9 to 2.10, so to accomodate this the tests had to be moved under ckannext/datagovuk.
Also included are improvements to github actions so that solr and pycsw images are only built when they are needed, not each time there is an update.