Upgrade ckan 2.10 #1383
Open
Upgrade ckan 2.10 #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to develop the stack in line with the production version of CKAN.
Also adds ckan.ini to replace production.ini Various templates are updated for styling changes
Testing that solr truncates its fields to 15k doesn't test the code in this repo. The max field length in Solr is now 32k and in the future it might be more so just remove the test.
sengi
reviewed
Jun 16, 2023
sengi
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
All looks reasonable to me, apart from the suspicious-looking secret string in the config file that you might need to change (unless it's unused, in which case I'd remove it or change it to something that's obviously a test/dummy value, whatever makes sense for your use case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Upgrade of CKAN to 2.10, this will be merged into main-2.10 after approval as the existing govuk stack is still using 2.9.3 and won't be able to support 2.10 until CKAN is replatformed.
Reference
https://trello.com/c/bEsbEk1m/1151-run-security-check-and-resolve-critical-issues