Add code for generating Julia benchmarks graph #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llewelld
force-pushed
the
matmul-julia-graph
branch
5 times, most recently
from
47355cc
to
112f8dd
Compare
mhauru
requested changes
May 20, 2024
implementation/matmul-julia/plots.jl
Outdated
| times = Dict() | ||
|
|
||
| for row in eachrow(df) | ||
| dims[row[:method]] = [2^n for n in 1:count] |
There was a problem hiding this comment.
I think this is a mismatch with the set of dimensions used in matmul.jl, line 270. That might also explain the unexpected scaling I commented on in the other PR.
There was a problem hiding this comment.
Nicely spotted! It should be dims = [2, 3, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128, 192, 256, 384, 512, 768, 1024] right?
I've updated the code here and also the figures on #43.
Adds Markus's code for generating benchmarks with increasingly large square matrices using multiple different approaches, including single and multi-threaded.. Updates the Julia benchmarking code so that results are output in CSV format. Random matrix generation now uses a very simple but explicit PRNG function for easy replication in other languages. There's a new script, written by Markus, to load in the CSV file and render a graph of the results, output in PNG and SVG format. I made some small changes, so any errors are mine. Co-authored-by: Markus Hauru <markus@mhauru.org>
llewelld
force-pushed
the
matmul-julia-graph
branch
from
112f8dd
to
c5d9f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Markus's code for generating benchmarks with increasingly large square matrices using multiple different approaches, including single and multi-threaded..
Updates the Julia benchmarking code so that results are output in CSV format.
Random matrix generation now uses a very simple but explicit PRNG function for easy replication in other languages.
There's a new script, written by Markus, to load in the CSV file and render a graph of the results, output in PNG and SVG format. I made some small changes, so any errors are mine.