Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1558): Discrepancy in addUsedSchema between v6 and v8 #2336

Closed

Conversation

Sachin-chaurasiya
Copy link

What issue does this pull request resolve?
Fixes #1558

What changes did you make?
I have added changes to check for addUsedSchema option, if it's false then skip the adding schema reference otherwise continue the flow.

Is there anything that requires more attention while reviewing?

NA

@Sachin-chaurasiya Sachin-chaurasiya changed the title fix( #1558): Discrepancy in addUsedSchema between v6 and v8 fix(#1558): Discrepancy in addUsedSchema between v6 and v8 Oct 16, 2023
@Sachin-chaurasiya
Copy link
Author

Hello @epoberezkin , I have run the tests locally and all tests are passing, however, CI is not passing, any help would be appreciated.

@Sachin-chaurasiya
Copy link
Author

Hello @epoberezkin, can you please review? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy in addUsedSchema between v6 and v8
1 participant