Export Ajv as a named export #2164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is solving an issue where it's impossible for me to import Ajv in a typescript project. This solves ajv-validator#2047 for me import { Ajv } from 'ajv';
jhford-scout24
force-pushed
the
allow-esm-import
branch
from
b4de190
to
6d61119
Compare
|
This feels wrong, adding another export. I think you might want to consult with @dsherret and ask him how he fixed dsherret/code-block-writer#42 - both the wrong way and the right way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is solving an issue where it's impossible for me to import Ajv in a typescript project. This solves #2047 for me
import { Ajv } from 'ajv';
What issue does this pull request resolve?
#2047
What changes did you make?
Added a single line exporting
Ajvin a slightly different way. I'm not sure if there are any tests on the exported interface.Is there anything that requires more attention while reviewing?
I don't think so -- this should be a no-op for those who don't use it, and the test suite (
yarn test) passes.