🚨 Source Appsflyer: Migrate to V2 Appsflyer API #38339
Open
+8,538
−3,144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
octavia-squidington-iii
added
area/connectors
AnjayGoel
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
AnjayGoel
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
changed the title
|
@AnjayGoel thank you for contributing! Running CI on this now. I'd like to remove the dockerfile and setup.py while we're here — would you mind rebasing if/when I ping you? |
natikgadzhi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
natikgadzhi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
force-pushed
the
fix-appsflyer-connector
branch
from
04e168c
to
a2b4276
Compare
AnjayGoel
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
AnjayGoel
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
AnjayGoel
force-pushed
the
fix-appsflyer-connector
branch
from
a2b4276
to
99c79c8
Compare
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
AnjayGoel
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
|
Hi @arielsnowik, I have added the streams and updated the readme. |
|
Hi @natikgadzhi , @aoelvp94, |
AnjayGoel
force-pushed
the
fix-appsflyer-connector
branch
from
4aa19c8
to
d0ec30d
Compare
AnjayGoel
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
AnjayGoel
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
Nice, thank you!! As long as the connector is properly tested and there is a clear way (by just reading readme...) for anyone to implement missing endpoints I think it would be ok to merge the PR. Kind Regards |
|
lgtm, @natikgadzhi and @marcosmarxm how is it possible to continue with this development? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrate from obsolete V1 API to V2.
Fixes #37403, #35667, #32446.
How
Appsflyer has deprecated & removed the V1 APIs. This PR migrates the connector to the API V2.
Review guide
User Impact
Users will have to replace the API V1 tokens with API V2 tokens as described here.
Can this PR be safely reverted and rolled back?