Make it possible to use Registry without requiring ArbiterService
#550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robjtede Whenever you have a few minutes, do you have any feedback about this one? |
|
FYI this is waiting on the other two checklist items before I can merge it. |
robjtede
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Docs
PR Checklist
Check your PR fulfills the following:
Tests for the changes have been added / updated.Overview
One of the downsides of the
ArbiterServicetrait is that it requiresDefault, which isn't always easy to implement. This pull request makes it possible to useRegistrywithout requiringArbiterService, by removing theArbiterService, and introducing atry_getmethod.