Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awc: gate TlsConnectorService behind any feature that uses it #3350

Merged
merged 3 commits into from May 14, 2024
Merged

awc: gate TlsConnectorService behind any feature that uses it #3350

merged 3 commits into from May 14, 2024

Conversation

asonix
Copy link
Contributor

@asonix asonix commented May 4, 2024

PR Type

Bug Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Gate this struct behind the features that use it, preventing a compiler warning introduced in 1.78 for unused code detection

@asonix asonix mentioned this pull request May 4, 2024
Merged
5 tasks
@asonix
Copy link
Contributor Author

asonix commented May 4, 2024

This still fails the public-api-diff because the prior version has the issue :p

@mpalmer mpalmer mentioned this pull request May 6, 2024
Open
5 tasks
@robjtede robjtede merged commit 44f502e into actix:master May 14, 2024
11 of 12 checks passed
@robjtede robjtede added A-awc project: awc B-semver-norelease change that does not require a release labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-awc project: awc B-semver-norelease change that does not require a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asonix @robjtede