Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actix-ws: take the encoded buffer when yielding rather than split it #435

Merged

Conversation

asonix
Copy link
Contributor

@asonix asonix commented May 18, 2024

PR Type

Bug fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

Prevent the actix-ws internal buffer from growing continuously by taking it rather than splitting it

same as in actix/actix-web#3369

@robjtede robjtede enabled auto-merge June 9, 2024 05:04
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍🏻

@robjtede robjtede added this pull request to the merge queue Jun 9, 2024
Merged via the queue into actix:master with commit 8195484 Jun 9, 2024
10 checks passed
@robjtede robjtede added B-semver-patch A-ws Project: actix-ws labels Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ws Project: actix-ws B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants