Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodiscard qualifier in Result class #241

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

kononovk
Copy link
Member

Purpose

Please use labels for this PR

Please describe the changes in this PR for reviewers

Related Information

  • Design document: ...
  • Bench PR: ...

Testing

  • This change is a trivial rework or code cleanup without any test coverage.
  • This change is already covered by existing tests.
  • This PR adds tests that were used to verify all changes.
  • There are tests in an external testing repository: ...

@kononovk kononovk requested a review from MBkkt as a code owner May 27, 2023 16:02
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5099701493

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 5021008928: 0.0%
Covered Lines: 1602
Relevant Lines: 1602

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #241 (a2e7fdf) into main (92b9550) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        68           
  Lines         1598      1602    +4     
=========================================
+ Hits          1598      1602    +4     
Impacted Files Coverage Δ
include/yaclib/util/result.hpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MBkkt MBkkt marked this pull request as draft May 27, 2023 16:37
Copy link
Member

@MBkkt MBkkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea but I don't like the solution.
At the same time I don't know another solution.
So don't merge for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants