Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always showing global value. #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haji-ali
Copy link

This pull request adds a section that always shows the Global value if the local value is being shown.

@minad
Copy link

minad commented Feb 5, 2023

Maybe use the term "Default Value" instead of "Global Value"?

@haji-ali
Copy link
Author

haji-ali commented Feb 6, 2023

Maybe use the term "Default Value" instead of "Global Value"?

I thought that using Emacs' original nomenclature would be prudent. The code

(progn
  (defvar foo '(1))
  (put 'foo 'standard-value (list (list 'quote '(2))))
  (setq-local foo '(3))
  (describe-variable 'foo))

Shows a *Help* buffer with

foo’s value is (3)
Original value was (2)
Local in buffer *scratch*; global value is (1)

With helpful and this patch, it shows

Value in #<buffer *scratch*>
(3)

Original Value
(2)

Global Value
(1)

@magthe
Copy link

magthe commented Aug 12, 2023

I've been trying to hunt down an issue with some hooks in my config and helpful not showing the global value made things a lot harder, until I realised this was the case and disabled helpful 😞

What is keeping this PR from being merged?

@rileyrg
Copy link

rileyrg commented Aug 12, 2023

Maybe use the term "Default Value" instead of "Global Value"?

Default and global have two very different meanings. A global value has a default that can be customised. But it's still global.

slotThe pushed a commit to slotThe/helpful that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants