Implementation of anatomical network visualisations #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DataFrame object and PathToFile
…ing a TypeError if unsupported type provided
…e - scona.visualisations
…rder to improve the process of saving a figure to file.
…raphBundle as a parameter
…network_measures()
… change calc_nodal_measures in calculate_nodal_measures function
…ingedRuslan-master
I've made a whole bunch of changes to the jupyter notebook...but they're all just "yes, and"-ing the work that wingedRuslan did! So it looks like a big diff, and it kinda is, but very much only on a surface level <3
This is mostly a style and readability update... I found the print outs of the warnings a little hard to parse in the jupyter notebook and then I've changed the comments to better fit my understanding of what was happening.
Makes sense to set those early, especially if there's going to be a warning that folks want to understand.
Kirstie review of visualisation tutorial
…according to the given orientation
…er value to make results reproducible
…eptable one for seaborn.barplot
|
link to compare nx plotting branch to Ruslan master branch (eg PR 121) |
… well-connected nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this is a good place to reference any issues that this PR addresses)
Created plotting anatomical network functionality
Issues: #126, #122
What's new?
plot_anatomical_networkfunction (+ some visualisation_helpers functions) and the tutorial to illustrate how to use new toolsWhat should a reviewer feedback on?
Is documentation clear?
Are the produced (and saved into a file) plots publication-ready and look nice?
Does anything need to be updated after merge?
(e.g the wiki or the WhitakerLab website)
Info on the website will be automatically updated