Split brain networks #125
Open
Split brain networks #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments, slightly restructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not at all. This is just a preview of my proposed changes to seperate the
BrainNetworkclass into two distinct subclasses:BinaryBrainNetworkandWeightedBrainNetwork.What's the context for this pull request?
(this is a good place to reference any issues that this PR addresses)
Ruslan discovered that when you run the
thresholdmethod on an already binarised graph it returns garbage.This made me think that there are potentially a lot of situations where treated a weighted network like a binary network or vice versa could be disastrous.
What's new?
My thinking is that the difference between a weighted and a binarised brain network should be very explicit since it's going to determine what sort of analyses we can do on it.
It should be possible to threshold a
WeightedBrainNetworkinto aBinaryBrainNetworkand it should be possible to initialise aWeightedBrainNetworkfrom a correlation matrix.A
BinaryBrainNetworkshould support all of the network analysis methods. We could run these on a weighted graph no problem, but they would tell us nothing about our data. We will record the original weightings on existentBinaryBrainNetworks in case we want to restrict our focus to fewer edges later (the specific use case being plotting).What should a reviewer feedback on?
Is this the right direction to go in to solve this problem.
Does anything need to be updated after merge?
(e.g the wiki or the WhitakerLab website)
docs and tutorials would certainly need to be updated, but it's a little early for that.