Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to java 21 #5163

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 17, 2024

This PR updates the used version of Java to 21. Similar to #2819.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.59%. Comparing base (d77d901) to head (c93e720).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5163      +/-   ##
============================================
+ Coverage     38.58%   38.59%   +0.01%     
  Complexity     2379     2379              
============================================
  Files           516      516              
  Lines         15315    15315              
  Branches       2957     2957              
============================================
+ Hits           5909     5911       +2     
+ Misses         9121     9120       -1     
+ Partials        285      284       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 marked this pull request as ready for review May 17, 2024 16:22
@vil02 vil02 marked this pull request as draft May 17, 2024 16:28
@vil02 vil02 marked this pull request as ready for review May 17, 2024 18:00
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 5ee98ee into TheAlgorithms:master May 19, 2024
4 checks passed
@vil02 vil02 deleted the migrate_to_java_21 branch May 19, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants