[BugFix] Fix the bug that partition by range(str2date) does not check parameters

[HangyuanLiu]

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.3
  • 3.2
  • 3.1
  • 3.0
  • 2.5

[starrocks-cr]

The most risky bug in this code is:
Missing null check for slotRef after calling AnalyzerUtils.getSlotRefFromFunctionCall(expr)

You can modify the code like this:

@@ -105,9 +108,20 @@ public void analyze(List<ColumnDef> columnDefs, Map<String, String> otherPropert
                     partitionType = ((CastExpr) expr).getTargetTypeDef().getType();
                 } else if (expr instanceof FunctionCallExpr) {
                     slotRef = AnalyzerUtils.getSlotRefFromFunctionCall(expr);
+
+                    // Ensure slotRef is not null before proceeding
+                    if (slotRef == null) {
+                        throw new AnalysisException("Failed to obtain SlotRef from function call.");
+                    }
+
                     Optional<ColumnDef> columnDef = columnDefs.stream()
                             .filter(c -> c.getName().equals(slotRef.getColumnName())).findFirst();
                     Preconditions.checkState(columnDef.isPresent());
                     slotRef.setType(columnDef.get().getType());
+
                     String functionName = ((FunctionCallExpr) expr).getFnName().getFunction().toLowerCase();
                     if (functionName.equals(FunctionSet.STR2DATE)) {
                         partitionType = Type.DATE;
+                        if (!PartitionFunctionChecker.checkStr2date(expr)) {
+                            throw new SemanticException("partition function check fail," +
+                                    " only support str2date(VARCHAR str, VARCHAR format)");
+                        }
                     }
                 } else {
                     throw an AnalysisException("Unsupported expr:" + expr.toSql());

This change ensures that a null slotRef (which could result from AnalyzerUtils.getSlotRefFromFunctionCall(expr) returning null, for expressions that do not directly involve a column reference) will be caught and handled properly, preventing potential NullPointerExceptions later in the code when operations on slotRef are attempted.

[sonarcloud]

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

[github-actions]

[FE Incremental Coverage Report]

✅ pass : 67 / 80 (83.75%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/sql/analyzer/PartitionFunctionChecker.java	51	64	79.69%	[31, 50, 55, 59, 83, 88, 94, 95, 101, 106, 117, 123, 128]
🔵	com/starrocks/sql/ast/ExpressionPartitionDesc.java	13	13	100.00%	[]
🔵	com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java	3	3	100.00%	[]

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

@Mergifyio backport branch-3.3

[mergify]

backport branch-3.3

✅ Backports have been created

• #45938 [BugFix] Fix the bug that partition by range(str2date) does not check parameters (backport #45838) has been created for branch branch-3.3

[HangyuanLiu]

https://github.com/Mergifyio backport branch-3.2

[mergify]

backport branch-3.2

✅ Backports have been created

• #46001 [BugFix] Fix the bug that partition by range(str2date) does not check parameters (backport #45838) has been created for branch branch-3.2