Change filePath to real path if it's an upload #4132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be added? What are the benefits of this change?
The current state breaks cases where the
UploadedFile
is not on a local disk such as S3. I discovered this issue in a project when using S3 for Livewire temporary files. Currently, one must do$myImport->import($uploadedFile->getRealPath())
instead of$myImport->import($uploadedFile)
when using S3 for temporary files.2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.
3️⃣ Does it include tests, if possible?
No. I'm not sure how to add tests for this without a remote disk connection. If there's a way let me know!
4️⃣ Any drawbacks? Possible breaking changes?
There shouldn't be. It's a small change and for local
UploadFile
instances it should work exactly as it did before.5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌
Thank you for building an awesome package!