Removed all filtering on recieve buffers #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JBernouli Can you explain this PR? We'd like to know the basis for your revision. |
|
In the can settings RXB1 and RXB0 control registers are masked with 0x60 and then setting it to 00 00 = Receives all valid messages using either Standard or Extended Identifiers that meet filter criteria; This resulted in not receiving extended ID Can messages, the change i made allowed that, maybe you guys are filtering on purpose? but the filters are never set up as far as i can see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove filtering on RX messages on receives for 2515 chip