-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock pandas sub-dependency and update pytz #4652
Open
axelstudios
wants to merge
4
commits into
develop
Choose a base branch
from
task/lock-pandas-subdependency
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelstudios
added
the
Maintenance
Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
label
Apr 29, 2024
Don't merge until v3.0 is officially released |
nllong
changed the title
Lock pandas sub-dependency
Lock pandas sub-dependency and update pytz
May 10, 2024
nllong
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
nllong
reviewed
May 24, 2024
@@ -21,8 +21,8 @@ django-extensions==3.1.3 | |||
django-model-utils==4.3.1 | |||
|
|||
# Time zones support - Do not update these without doing significant testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# Time zones support - Do not update these without doing significant testing! | |
# Time zones support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO NOT MERGE
Maintenance
Tag as maintenance if the issue relates to general cleanup, maintenance, etc. Do not delete label.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
Several CI actions independently build the docker image, and pandas wheel compilation was adding ~35 minutes to the tasks
What's this PR do?
Locks pandas to v2.2.2 in the
buildingid
dependencyUpdates
pytz
andpython-dateutil
to the latest versions for compatibilityCI performance improvement:
How should this be manually tested?
Check that all timezone and date functionality still work as expected