-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change config validation order #1520
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: bbf5533 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success742 tests passing in 104 suites. Report generated by 🧪jest coverage report action from bbf5533 |
2e40211
to
46903a5
Compare
|
||
if (configPath) { | ||
try { | ||
const { document, resolvedRefMap } = await resolveConfigFileAndRefs({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to resolve it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configPath
is not mandatory, we will resolve the configuration even without it.
But when present additional resolution steps are required.
ee422d7
to
9469453
Compare
9469453
to
15c6fea
Compare
What/Why/How?
Changes in this PR also results in code changes for Project
Affected changes & tests => https://github.com/Redocly/redocly/pull/7855
Reference
Closes #1223
Testing
Screenshots (optional)
Check yourself
Security