fix: fix issues with https-agent-proxy for cli and openapi-core packages #1493
+281
−96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Adding https-proxy-agent package to fix issues with requests when using CLI behind proxy. Create better mechanism for handling
env.REDOCLY_DOMAIN
usage in few modules.Now if you need to run the CLI tool behind a proxy, you can use the HTTP_PROXY and HTTPS_PROXY environment variables to configure the proxy settings.
https-proxy-agent
package was used fornode-fetch
requests. Now we pass agent for everyfetchWithTimeout
request, as well as other regularfetch
request.After encountering problems with some of the packages from
https-proxy-agent
dependencies, we had to ignore this package for browser environment, by modyfingpackages/core/package.json
like so:This is 3rd attempt to release this fix after previous two were reverted: #1461 and #1433
Reference
Reverts #1468
Resolves #1404
Fixes #529
Fixes #1146
Resolves #1433
Testing
Fixed unit tests. Tested with few CLI commands:
push
,lint
etc.Screenshots (optional)
n/a
Has code been changed?
Yes
Check yourself
Security