refactor: move from styled-components to vanilla extract #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- css - vite-plugin
just the bootstrap
…es, such as: - png - svg - ttf - eot - woff - woff2
Each cursor has now its own class! 🎉
themes need to be global since global theme make use of CSS variables from normal themes
- still WIP
- border widths - border styles
AND NOW WE"RE TALKING
- drop `size` one. It isn't from Avatar anymore. We should have it on Frame instead
Closed
missed `package.json`
ggdaltoso
changed the title
and removing all `React.*` declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed everything. That's it. But basically removed the
styled-componentdependency to usevanilla-extract.Why? Better support.
styled-componentsis great and I appreciate it. But, do we need a CSS-in-JS library for React95?? 🤔No. We don't.
With
vanilla-extractwe can rely on great TS support + CSS output.It has been fun to maintain this library. You should give it a try 👀
Notable changes
Well, with no more
styled-componentsdependency, it becomes easier to install the library. You now need to install just the lib itself. There is no need to install missing types and/or dependencies.And that's it.
Visual changes
I also did a look around and updated some components. There are several pixel dances but they should look pretty much the same.
The Tree component was refactored to not use images and to have a more precise layout as we have in the original w95.
More options in TitleBar options with new icons