fix: handle CORS pre-flight requests correctly #3052
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenceisla
force-pushed
the
options-preflight
branch
from
c128dfc
to
d781204
Compare
| @@ -44,3 +44,7 @@ corsPolicy corsAllowedOrigins req = case lookup "origin" headers of | |||
| -- Impossible case, Middleware.Cors will not evaluate this when | |||
| -- the Access-Control-Request-Headers header is not set. | |||
| Nothing -> [] | |||
| -- The library makes "OPTIONS" requests fail when the "Origin" header is present | |||
There was a problem hiding this comment.
Ah, I failed to mention the wai-cors library. In summary, it treats an OPTION request with Origin as a pre-flight when it shouldn't IMO. Relevant code.
I added more info here: #3027 (comment). The solution is as I mentioned there or patch the library to remove that validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3027
Lets the library handle errors when a pre-flight request fails.