Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write something useful #4

Open
wants to merge 4 commits into
base: own-n
Choose a base branch
from
Open

write something useful #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63d41f4
add hammerhead maintainer
sujitroy Aug 10, 2017
7501cef
added mHammerheadPlusUrl
sujitroy Aug 10, 2017
32a6ad2
derp
sujitroy Aug 10, 2017
e18020e
Update Maintainers.java
xaif Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion res/values/ownrom_maintainers_list.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
<string name="device_google_angler_summary">Matthijs Markvoort (mmarkvoort)</string>
<string name="device_google_bullhead">Nexus 5x (Bullhead)</string>
<string name="device_google_bullhead_summary">Akash Srivastava (markakash)</string>
<string name="device_google_hammerhead">Nexus 5 (Hammerhead)</string>
<string name="device_google_bullhead_summary">Xaif (Xaif)</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String derp

<string name="device_google_mako">Nexus 4 (Mako)</string>
<string name="device_google_mako_summary">Victor Linfield (vilinfield)</string>

Expand Down Expand Up @@ -88,7 +90,7 @@
<string name="device_xiaomi_cancro">Mi3-Mi4 (Cancro)</string>
<string name="device_xiaomi_cancro_summary">Nguyen Thinh (Thinhx2)</string>
<string name="device_xiaomi_armani">Redmi 1s (Armani)</string>
<string name="device_xiaomi_armani_summary">Sujit Roy (sujitroy)</string>
<string name="device_xiaomi_armani_summary">Sujit Roy (sskr_)</string>

<!-- ANDROİD ONE -->

Expand Down
7 changes: 6 additions & 1 deletion src/com/own/settings/owncenter/tabs/Maintainers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public class Maintainers extends SettingsPreferenceFragment {
// Google
private String KEY_ANGLER_MAINTAINER_PLUS_LINK = "angler_maintainer_plus_link";
private String KEY_BULLHEAD_MAINTAINER_PLUS_LINK = "bullhead_maintainer_plus_link";
private String KEY_HAMMERHEAD_MAINTAINER_PLUS_LINK = "hammerhead_maintainer_plus_link";
private String KEY_MAKO_MAINTAINER_PLUS_LINK = "mako_maintainer_plus_link";

// LG
Expand Down Expand Up @@ -75,6 +76,7 @@ public class Maintainers extends SettingsPreferenceFragment {
// Google
private Preference mAnglerPlusUrl;
private Preference mBullheadPlusUrl;
private Preference mHammerheadPlusUrl;
private Preference mMakoPlusUrl;

// LG
Expand Down Expand Up @@ -111,11 +113,12 @@ public void onCreate(Bundle savedInstanceState) {
// OnePlus
mOneplus3PlusUrl = findPreference(KEY_ONEPLUS3_MAINTAINER_PLUS_LINK);
mOneplus2PlusUrl = findPreference(KEY_ONEPLUS2_MAINTAINER_PLUS_LINK);
mOneplusOnePlusUrl = findPreference(KEY_ONEPLUSONE_MAINTAINER_PLUS_LINK);
mOneplusOnePlusUrl = findPreference(KEY_ONEPLUSONE_MAINTAINER_PLUS_LINK);

// Google
mAnglerPlusUrl = findPreference(KEY_ANGLER_MAINTAINER_PLUS_LINK);
mBullheadPlusUrl = findPreference(KEY_BULLHEAD_MAINTAINER_PLUS_LINK);
mHammerheadPlusUrl = findPreference(KEY_HAMMERHEAD_MAINTAINER_PLUS_LINK);
mMakoPlusUrl = findPreference(KEY_MAKO_MAINTAINER_PLUS_LINK);

// LG
Expand Down Expand Up @@ -161,6 +164,8 @@ public boolean onPreferenceTreeClick(Preference preference) {
launchUrl("https://plus.google.com/111706744947764135950");
} else if (preference == mBullheadPlusUrl) {
launchUrl("https://plus.google.com/+AkashSrivastava1926");
} else if (preference == mHammerheadPlusUrl) {
launchUrl("https://plus.google.com/+huzaifaamirka46");
} else if (preference == mMakoPlusUrl) {
launchUrl("https://plus.google.com/+VictorLinfield");

Expand Down