Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all link navigation functions to clarify appropriate usage #2333

Merged
merged 9 commits into from
May 21, 2024
Merged

Update all link navigation functions to clarify appropriate usage #2333

merged 9 commits into from
May 21, 2024

Conversation

AE-MS
Copy link
Contributor

@AE-MS AE-MS commented May 17, 2024

Description

This library has a lot of link navigation functions and it can be confusing to know what they all are or how to use them. In this change I updated the documentation for all of them to clarify intended use and link between them for easy navigation.

Additional Requirements

Change file added:

Yes

@AE-MS AE-MS marked this pull request as ready for review May 17, 2024 21:33
@AE-MS AE-MS requested a review from a team as a code owner May 17, 2024 21:33
shrshindeMSFT
shrshindeMSFT previously approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@shrshindeMSFT shrshindeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for making these changes 🚢

JoshuaPartlow
JoshuaPartlow reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@JoshuaPartlow JoshuaPartlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and added some comments/suggestions. If you have any questions, just let me know.

packages/teams-js/src/public/app.ts Outdated Show resolved Hide resolved
packages/teams-js/src/public/pages.ts Outdated Show resolved Hide resolved
packages/teams-js/src/public/app.ts Outdated Show resolved Hide resolved
packages/teams-js/src/public/pages.ts Outdated Show resolved Hide resolved
packages/teams-js/src/public/pages.ts Outdated Show resolved Hide resolved
packages/teams-js/src/public/pages.ts Outdated Show resolved Hide resolved
packages/teams-js/src/public/pages.ts Show resolved Hide resolved
packages/teams-js/src/public/pages.ts Show resolved Hide resolved
packages/teams-js/src/public/publicAPIs.ts Outdated Show resolved Hide resolved
@AE-MS AE-MS dismissed stale reviews from noahdarveau-MSFT and shrshindeMSFT via a1917fa May 20, 2024 23:42
@AE-MS AE-MS enabled auto-merge (squash) May 21, 2024 02:24
@AE-MS AE-MS merged commit 11616ac into main May 21, 2024
21 checks passed
@AE-MS AE-MS deleted the AE_MS/link_docs branch May 21, 2024 02:28
shrshindeMSFT pushed a commit that referenced this pull request May 22, 2024
@AE-MS @shrshindeMSFT
Update all link navigation functions to clarify appropriate usage (#2333
b429900 
)

* First pass at updated docs

* More doc updates

* More doc updates

* More doc updates

* More doc updates

* changefile

* Incorporate docs feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaPartlow JoshuaPartlow JoshuaPartlow approved these changes

@shrshindeMSFT shrshindeMSFT shrshindeMSFT approved these changes

@noahdarveau-MSFT noahdarveau-MSFT noahdarveau-MSFT left review comments

@erikadoyle erikadoyle Awaiting requested review from erikadoyle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AE-MS @JoshuaPartlow @shrshindeMSFT @noahdarveau-MSFT