New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish xctest result for screenshots and diagnostic logs #2306
Open
KangxuanYe
wants to merge
16
commits into
main
Choose a base branch
from
kx/publish_screenshots
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KangxuanYe
force-pushed
the
kx/publish_screenshots
branch
from
May 7, 2024 00:36
3aee6af
to
fe01603
Compare
KangxuanYe
changed the title
[Still Testing / Do not review] Publish xctest result for screenshots
Publish xctest result for screenshots and diagnostic logs
May 7, 2024
jekloudaMSFT
previously approved these changes
May 7, 2024
KangxuanYe
force-pushed
the
kx/publish_screenshots
branch
from
May 8, 2024 21:20
8005011
to
7f7039b
Compare
TrevorJoelHarris
previously approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
This PR is to ALWAYS publish the artifacts on iOS E2E testing pipeline for the convenience of investigating some flaky failures if those happen. You could go to pipeline and click "published artifacts". Then you will find two folders which are called iOSDebugLogs - iosE2ETestPlanA and iOSDebugLogs - iosE2ETestPlanB.
Those folders will always be there for each run but it only worth to take a look into those folders if something fails on iOS E2E pipelines. If all tests are passed successfully, publishing process should only take seconds and I think it is okay. to put always condition on those tasks since sometimes, pipeline will timeout and we also would like to know why and need some diagnostic info.
Unit Tests added: No
End-to-end tests added: No