Update .npmrc location in release helper scripts #2303
Conversation
| Set-Content -Path $Env:SYSTEM_DEFAULTWORKINGDIRECTORY/microsoft-teams-library-js-pipeline/NPMFeed/.npmrc -Value "//registry.npmjs.org/:_authToken=$Env:NPM_TOKEN" |
There was a problem hiding this comment.
End of line is required
There was a problem hiding this comment.
Are you sure? We've already been using this script without issue, I'm just updating the path
There was a problem hiding this comment.
Yes, I understand but as per github guidelines it's mandate to have EOL. You can see the red circle with dash in this PR.
https://gist.github.com/camh-/1bebfcff1b0f814e9b191edc60d5206b
There was a problem hiding this comment.
It's not related to execution; it is related to code-readability.
| @@ -1,4 +1,4 @@ | |||
| $version = Get-ChildItem -Path $Env:SYSTEM_DEFAULTWORKINGDIRECTORY/_OfficeDev.microsoft-teams-library-js/CDNFeed -Directory -Name | |||
| $version = Get-ChildItem -Path $Env:SYSTEM_DEFAULTWORKINGDIRECTORY/microsoft-teams-library-js-pipeline/CDNFeed -Directory -Name | |||
| Write-Host "Releasing version $version" | |||
| Write-Host "CDN: https://res-sdf.cdn.office.net/teams-js/$version/js/MicrosoftTeams.min.js " | |||
| Write-Host "NPM: https://www.npmjs.com/package/@microsoft/teams-js/v/$version" | |||
|
Small question here, but would this change impact the current releases. If this pipeline isn't working as expected and we need to fallback to the previous system we have in place, will this still work? Since these scripts are published as artifacts with each build. We can test this by disabling every step except for the powershell scripts in our current SDF release. |
Good call, I'll make a new script for the yaml pipeline so we don't break current release |
* Update .npmrc location * Changefile * Update @microsoft-teams-js-b63da2d9-3e02-4b83-9664-78aa8f49c713.json * use new scripts for onebranch pipelines --------- Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
* Update .npmrc location * Changefile * Update @microsoft-teams-js-b63da2d9-3e02-4b83-9664-78aa8f49c713.json * use new scripts for onebranch pipelines --------- Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
I had to rename the pipeline reference name we were using in our release pipeline to be compliant with the OneBranch template. This PR updates that name in our release helper scripts as well.