Const enum recommendation Eslint plugin

packages/teams-js/.eslintrc.js

@@ -3,7 +3,7 @@ module.exports = {
   parserOptions: {
     project: './tsconfig.eslint.json',
   },
-  plugins: ['strict-null-checks'],
+  plugins: ['strict-null-checks', 'recommend-const-enums'],
   rules: {
     '@typescript-eslint/interface-name-prefix': 'off',
     '@typescript-eslint/no-namespace': 'off',
@@ -13,5 +13,6 @@ module.exports = {
     ],
     'no-inner-declarations': 'off',
     'strict-null-checks/all': 'warn',
+    'recommend-const-enums/recommend-const-enums': 'warn',
   },
 };

packages/teams-js/eslint-rules/eslint-plugin-recommend-const-enums/index.js

@@ -0,0 +1,4 @@
+const recommendConstEnumsRule = require('./recommendConstEnums.js');
+
+const plugin = { rules: { 'recommend-const-enums': recommendConstEnumsRule } };
+module.exports = plugin;

packages/teams-js/eslint-rules/eslint-plugin-recommend-const-enums/package.json

@@ -0,0 +1,16 @@
+{
+  "name": "eslint-plugin-recommend-const-enums",
+  "version": "0.0.0",
+  "license": "MIT",
+  "author": "Noah",
+  "description": "Recommend using const enums",
+  "type": "commonjs",
+  "keywords": [
+    "eslint",
+    "eslint-plugin",
+    "eslintplugin"
+  ],
+  "peerDependencies": {
+    "eslint": ">=5.0.0"
+  }
+}

packages/teams-js/eslint-rules/eslint-plugin-recommend-const-enums/recommendConstEnums.js

@@ -0,0 +1,32 @@
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Recommend using const enums if possible to minimize bundle size',
+      category: 'Best Practices',
+      recommended: true,
+    },
+    fixable: 'code',
+    schema: [],
+  },
+
+  create: function (context) {
+    return {
+      TSEnumDeclaration: function (node) {
+        const enumName = node.id.name;
+        const enumType = node.const ? 'const' : 'regular';
+
+        if (enumType === 'regular') {
+          context.report({
+            node: node,
+            message: `Please consider if you can use a const enum for ${enumName} to minimize bundle size. If not, add "/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */" to the line above to disable this warning.`,
+            severity: 2,
+            //fix(fixer) {
+            //  return fixer.insertTextBefore(node, 'const ');
+            //},
+          });
+        }
+      },
+    };
+  },
+};

packages/teams-js/package.json

@@ -24,7 +24,8 @@
     "debug": "^4.3.3"
   },
   "devDependencies": {
-    "@types/debug": "^4.1.7"
+    "@types/debug": "^4.1.7",
+    "eslint-plugin-recommend-const-enums": "file:./eslint-rules/eslint-plugin-recommend-const-enums"
   },
   "license": "MIT",
   "files": [

packages/teams-js/src/private/remoteCamera.ts

@@ -58,6 +58,7 @@ export namespace remoteCamera {
    * @internal
    * Limited to Microsoft-internal use
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum ControlCommand {
     Reset = 'Reset',
     ZoomIn = 'ZoomIn',

packages/teams-js/src/public/app.ts

@@ -227,6 +227,7 @@ export namespace app {
   /**
    * Describes errors that caused app initialization to fail
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum FailedReason {
     /**
      * Authentication failed
@@ -246,6 +247,7 @@ export namespace app {
    * Describes expected errors that occurred during an otherwise successful
    * app initialization
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum ExpectedFailureReason {
     /**
      * There was a permission error
@@ -272,6 +274,7 @@ export namespace app {
   /**
    * Represents the failed request sent during a failed app initialization.
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export interface IFailedRequest {
     /**
      * The reason for the failure
@@ -286,6 +289,7 @@ export namespace app {
   /**
    * Represents the failure request sent during an erroneous app initialization.
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export interface IExpectedFailureRequest {
     /**
      * The reason for the failure

packages/teams-js/src/public/constants.ts

@@ -1,4 +1,5 @@
 /** HostClientType represents the different client platforms on which host can be run. */
+/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
 export enum HostClientType {
   /** Represents the desktop client of host, which is installed on a user's computer and runs as a standalone application. */
   desktop = 'desktop',
@@ -78,6 +79,7 @@ export const enum HostName {
  * If the app is running in the content context, the developer may want to display information relevant to
  * the content the user is currently viewing.
  */
+/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
 export enum FrameContexts {
   /**
    * App's frame context from where settings page can be accessed.
@@ -104,6 +106,7 @@ export enum FrameContexts {
  * Indicates the team type, currently used to distinguish between different team
  * types in Office 365 for Education (team types 1, 2, 3, and 4).
  */
+/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
 export enum TeamType {
   /** Represents a standard or classic team in host that is designed for ongoing collaboration and communication among a group of people. */
   Standard = 0,
@@ -120,6 +123,7 @@ export enum TeamType {
 /**
  * Indicates the various types of roles of a user in a team.
  */
+/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
 export enum UserTeamRole {
   /** Represents that the user is an owner or administrator of the team. */
   Admin = 0,

packages/teams-js/src/public/interfaces.ts

@@ -990,6 +990,7 @@ export function isSdkError(err: unknown): err is SdkError {
 }
 
 /** Error codes used to identify different types of errors that can occur while developing apps. */
+/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
 export enum ErrorCode {
   /**
    * API not supported in the current platform.
@@ -1077,6 +1078,7 @@ export interface AdaptiveCardVersion {
 /**
  * Currently supported Mime type
  */
+/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
 export enum ClipboardSupportedMimeType {
   TextPlain = 'text/plain',
   TextHtml = 'text/html',

packages/teams-js/src/public/mail.ts

@@ -79,6 +79,7 @@ export namespace mail {
   }
 
   /** Defines compose mail types. */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum ComposeMailType {
     /** Compose a new mail message. */
     New = 'new',

packages/teams-js/src/public/marketplace.ts

@@ -226,6 +226,7 @@ export namespace marketplace {
    * Represents the status of the cart.
    * @beta
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum CartStatus {
     /**
      * @hidden

packages/teams-js/src/public/media.ts

@@ -610,6 +610,7 @@ export namespace media {
    * @beta
    * Events which are used to communicate between the app and the host client during the media recording flow
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum MediaControllerEvent {
     /** Start recording. */
     StartRecording = 1,
@@ -638,6 +639,7 @@ export namespace media {
   /**
    * The modes in which camera can be launched in select Media API
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum CameraStartMode {
     /** Photo mode. */
     Photo = 1,
@@ -652,6 +654,7 @@ export namespace media {
   /**
    * Specifies the image source
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum Source {
     /** Image source is camera. */
     Camera = 1,
@@ -662,6 +665,7 @@ export namespace media {
   /**
    * Specifies the type of Media
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum MediaType {
     /** Media type photo or image */
     Image = 1,
@@ -686,6 +690,7 @@ export namespace media {
   /**
    * ID contains a mapping for content uri on platform's side, URL is generic
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum ImageUriType {
     /** Image Id. */
     ID = 1,
@@ -696,6 +701,7 @@ export namespace media {
   /**
    * Specifies the image output formats.
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum ImageOutputFormats {
     /** Outputs image.  */
     IMAGE = 1,

packages/teams-js/src/public/meeting.ts

@@ -319,6 +319,7 @@ export namespace meeting {
   /**
    * Reasons for the app's microphone state to change
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   enum MicStateChangeReason {
     HostInitiated,
     AppInitiated,

packages/teams-js/src/public/menus.ts

@@ -52,6 +52,7 @@ export namespace menus {
   /**
    * Defines how a menu item should appear in the NavBar.
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum DisplayMode {
     /**
      * Only place this item in the NavBar if there's room for it.

packages/teams-js/src/public/videoEffects.ts

@@ -101,6 +101,7 @@ export namespace videoEffects {
    * Predefined failure reasons for preparing the selected video effect
    * @beta
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum EffectFailureReason {
     /**
      * A wrong effect id is provide.

packages/teams-js/src/public/visualMedia.ts

@@ -71,6 +71,7 @@ export namespace visualMedia {
    *
    * @beta
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum CameraRestriction {
     /** User can move between front and back camera */
     FrontOrRear = 1,
@@ -85,6 +86,7 @@ export namespace visualMedia {
    *
    * @beta
    */
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   export enum Source {
     /** The camera is the source of visual media. */
     Camera = 1,

packages/teams-js/test/promiseTester.ts

@@ -1,3 +1,4 @@
+/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
 export enum PromiseState {
   Pending = 'pending',
   Resolved = 'resolved',

packages/teams-js/test/public/runtime.spec.ts

@@ -282,6 +282,7 @@ describe('runtime', () => {
     return `${version}.1`;
   }
 
+  /* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
   enum OlderOrNewerVersions {
     OlderVersions,
     NewerVersions,

packages/teams-js/test/resultValidation.ts

@@ -1,5 +1,6 @@
 import { MessageRequest } from './utils';
 
+/* eslint-disable-next-line recommend-const-enums/recommend-const-enums */
 export enum MatcherType {
   ToBe,
   ToStrictEqual,