-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix: Clipboard capability throwing error DOMException: Document not focused
#2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there an E2E test that can catch this problem? |
change/@microsoft-teams-js-1f05f3e0-286f-4831-8747-649c0e47e551.json
Outdated
Show resolved
Hide resolved
Right now, we don't have infra to catch this e2e test case problem, but as a follow up I'll add something to pipelines which will test against desktop clients. |
…1.json Co-authored-by: Trevor Harris <trharris@microsoft.com>
noahdarveau-MSFT
approved these changes
Mar 26, 2024
jadahiya-MSFT
approved these changes
Mar 26, 2024
alexneyman-MSFT
pushed a commit
that referenced
this pull request
Apr 17, 2024
…not focused` (#2201) * Update clipboard responses for desktop client * changefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
Currently developers are facing issue in desktop clients on clipboard capability. This PR adds changes to how
App
interacts with parent window over JSON string rather thanblob
.Main changes in the PR:
Unit Tests added:
Yes
End-to-end tests added:
N/A
Additional Requirements
Change file added:
Yes
Issue Link: Clipboard api throws 'NotAllowedError: Failed to execute 'write' on 'Clipboard': Document is not focused