Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Clipboard capability throwing error DOMException: Document not focused #2201

Merged
merged 7 commits into from
Mar 26, 2024

Conversation

shrshindeMSFT
Copy link
Contributor

For more information about how to contribute to this repo, visit this page.

Description

Currently developers are facing issue in desktop clients on clipboard capability. This PR adds changes to how App interacts with parent window over JSON string rather than blob.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Added desktop to use JSON string to read response from clipboard.
  2. Added desktop to unit tests.

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

Yes

End-to-end tests added:

N/A

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

Yes

Issue Link: Clipboard api throws 'NotAllowedError: Failed to execute 'write' on 'Clipboard': Document is not focused

@shrshindeMSFT shrshindeMSFT requested a review from a team as a code owner March 5, 2024 22:58
@shrshindeMSFT shrshindeMSFT enabled auto-merge (squash) March 6, 2024 00:05
@AE-MS
Copy link
Contributor

AE-MS commented Mar 7, 2024

Is there an E2E test that can catch this problem?

@shrshindeMSFT
Copy link
Contributor Author

Is there an E2E test that can catch this problem?

Right now, we don't have infra to catch this e2e test case problem, but as a follow up I'll add something to pipelines which will test against desktop clients.

…1.json

Co-authored-by: Trevor Harris <trharris@microsoft.com>
@shrshindeMSFT shrshindeMSFT merged commit c6ece37 into main Mar 26, 2024
20 checks passed
@shrshindeMSFT shrshindeMSFT deleted the shrshinde/clipboardDesktopBugFix branch March 26, 2024 22:23
alexneyman-MSFT pushed a commit that referenced this pull request Apr 17, 2024
…not focused` (#2201)

* Update clipboard responses for desktop client

* changefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants