Updated TeamsJS CC Matrix App #2074
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AE-MS
reviewed
Jan 12, 2024
apps/teamsjs-cc-app/readme.md
Outdated
| @@ -0,0 +1,93 @@ | |||
| # TeamsJS Capability Checker | |||
There was a problem hiding this comment.
Can this file have some info about what this app is and what it's for?
Some of the info about how to run it is good and helpful and should stay -- but some details specific to this app would be good.
AE-MS
reviewed
Jan 12, 2024
apps/teamsjs-cc-app/tsconfig.json
Outdated
| "resolveJsonModule": true, | ||
| "isolatedModules": true, | ||
| "noEmit": true, | ||
| "jsx": "react-jsx" |
There was a problem hiding this comment.
Consider alphabetizing these
AE-MS
reviewed
Jan 12, 2024
| "manifestVersion": "1.16", | ||
| "version": "1.0.2", | ||
| "id": "${{TEAMS_APP_ID}}", | ||
| "packageName": "com.microsoft.teams.extension", |
AE-MS
reviewed
Jan 12, 2024
|
For future reference, putting screenshots of the app into the PR request can be helpful to reviewers. |
|
I'll review more of the code once the tests are passing and the code has been updated to latest main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
Main changes in the PR:
Validation
Validation performed:
None
Unit Tests added:
Not necessary, sample app
End-to-end tests added:
No
Additional Requirements
Change file added:
Not needed as this doesn't impact client facing code