Skip to content

Commit

Permalink
Adding UUIDs to MessageRequests and MessageResponses (#2240)
Browse files Browse the repository at this point in the history
* Adding UUIDs to MessageRequests and MessageResponses

* Committing changefile

* Added in MessageID and MessageUUID types, added in testing for UUID communication and id as numbers communication

* Changing waitForResponse to have input of type MessageUUID

* Updated references to use MessageID and MessageUUID

* Fixed lint error

* Created BaseUUID type

* Added validation for uuid to handleParentMessage

* Only validate UUIDs if there is one

* Added in MessageUUID object

* Testing new changes to UUID

* Added in serialization of objects

* Updated to address PR feedback

* Added comment describing MessageID vs MessageUUID

* Added in helper function

* Removing comment since map.delete was verified to work correctly

* Moved uuid object to interfaces.ts for more general use

* Replaced Function in Map declarations

* Updated to use serialized and deserialized Message Response objects

* Added in unit tests for UUID class

* Fixed lint error

* Updating tests

* Moved uuid object to new file uuidObject.ts, edited changefile verbage

* Added in unit tests for testing callback map deletion and functionality

* Removed unnused import

* Added in logging for when a callbackID fails to be generated

* Fixed a typo in communication spec

* Updated serialization and deserialization and uuid toString function

* Reverted toString() change due to compatibility issues

* Removing unnecessary map clear due to already clearing in uninitialize and removeHandlers

* Fixed an issue with removing message ids

* Reverting uuid back to private

---------

Co-authored-by: Trevor Harris <trharris@microsoft.com>
Co-authored-by: AE ( ͡ಠ ʖ̯ ͡ಠ) <36546967+AE-MS@users.noreply.github.com>
  • Loading branch information
3 people authored and alexneyman-MSFT committed May 17, 2024
1 parent 3120c33 commit 9658831
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Added `uuid` parameter to `MessageRequest` and `MessageResponse` interfaces",
"packageName": "@microsoft/teams-js",
"email": "jadahiya@microsoft.com",
"dependentChangeType": "patch"
}

0 comments on commit 9658831

Please sign in to comment.