fix(chat): string #11505
Merged
fix(chat): string #11505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #11505 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 536 536
Lines 32659 32666 +7
Branches 6352 6321 -31
=======================================
+ Hits 28872 28879 +7
- Misses 1842 1843 +1
+ Partials 1945 1944 -1
|
tecton
requested review from
timngmsft,
sffamily,
therealjohn,
supkasar,
1openwindow,
HuihuiWu-Microsoft and
nliu-ms
as code owners
supkasar
reviewed
Apr 29, 2024
supkasar
reviewed
Apr 29, 2024
packages/vscode-extension/test/chat/commands/create/createCommandHandler.test.ts
Outdated
Show resolved
Hide resolved
1openwindow
previously approved these changes
May 17, 2024
supkasar
previously approved these changes
May 17, 2024
supkasar
approved these changes
May 17, 2024
1openwindow
approved these changes
May 17, 2024
This was referenced May 17, 2024
LongOddCode
pushed a commit
that referenced
this pull request
May 17, 2024
* fix(chat): string * fix: restrict template match number * fix: ut * fix: ut coverage * fix: comment * fix: string and API change * fix: ut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bug: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27863463
Effect:
