fix: bug 27332508: disable auto install dependencies for manifest-only office add-in #11234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanwenhe
reviewed
Mar 29, 2024
richard6094
requested review from
1openwindow,
HuihuiWu-Microsoft,
nliu-ms,
tecton,
jayzhang,
xzf0587 and
LongOddCode
as code owners
jayzhang
previously approved these changes
Apr 29, 2024
| @@ -751,7 +751,7 @@ | |||
| { | |||
| "command": "fx-extension.localdebug", | |||
| "title": "%teamstoolkit.commands.localDebug.title%", | |||
| "enablement": "!fx-extension.commandLocked", | |||
| "enablement": "!fx-extension.commandLocked && !fx-extension.isOfficeAddIn || fx-extension.isOfficeAddIn && !fx-extension.isManifestOnlyOfficeAddIn", | |||
There was a problem hiding this comment.
I think the command can only be enabled when command unlocked
HuihuiWu-Microsoft
previously approved these changes
May 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #11234 +/- ##
==========================================
+ Coverage 87.80% 88.37% +0.56%
==========================================
Files 496 536 +40
Lines 29744 32484 +2740
Branches 5777 6399 +622
==========================================
+ Hits 26118 28708 +2590
- Misses 1778 1840 +62
- Partials 1848 1936 +88
|
HuihuiWu-Microsoft
approved these changes
May 17, 2024
jayzhang
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: bug 27332508: disable auto install dependencies for manifest-only office add-in