Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 7 - Implement New toolkit version csharp samples #1256

Merged
merged 12 commits into from
May 31, 2024
Merged

PR 7 - Implement New toolkit version csharp samples #1256

merged 12 commits into from
May 31, 2024

Conversation

Harikrishnan-MSFT
Copy link
Contributor

@Harikrishnan-MSFT Harikrishnan-MSFT commented May 8, 2024 •
edited

Sample List -

  1. msgext-action-preview
  2. bot-sso-adaptivecard
  3. msgext-action
  4. bot-join-team-using-qr-code
  5. bot-receive-channel-messages-withRSC

@Harikrishnan-MSFT Harikrishnan-MSFT added the DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet. label May 8, 2024
Alive-Fish
Alive-Fish approved these changes May 16, 2024
View reviewed changes
Copy link

@Alive-Fish Alive-Fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. Merge it before testing the samples.

@Harikrishnan-MSFT
Copy link
Contributor Author

Build Pipeline -
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/9253458588
image

@Harikrishnan-MSFT Harikrishnan-MSFT removed the DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet. label May 30, 2024
Mohammed-MSFT
Mohammed-MSFT approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@Mohammed-MSFT Mohammed-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct approving...

Pawank-MSFT
Pawank-MSFT approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, Approving!

@Harikrishnan-MSFT Harikrishnan-MSFT merged commit 6ff416d into main May 31, 2024
1 check passed
@Prithvi-MSFT Prithvi-MSFT mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alive-Fish Alive-Fish Alive-Fish approved these changes

@Mohammed-MSFT Mohammed-MSFT Mohammed-MSFT approved these changes

@Pawank-MSFT Pawank-MSFT Pawank-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Harikrishnan-MSFT @Alive-Fish @Mohammed-MSFT @Pawank-MSFT