Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify entry/complete document terminology (3.0.4) #3820

Merged
merged 1 commit into from
May 23, 2024

Conversation

handrews
Copy link
Member

@handrews handrews commented May 19, 2024

@ralfhandl caught that our phrasing here seemed to imply only one document with an OpenAPI Object, which was emphatically not the intention.

Clarifies that there can be multiple complete OpenAPI documents, only one of which is an entry OpenAPI document. The term "complete OpenAPI document" is useful in other guidance (to be tidied up in a later PR as it is currently only mentioned in 3.1.1).

Also added "entry document" as shorthand for "entry OpenAPI document" because I know I've used it that way and it reads better in some contexts.

@handrews handrews added the clarification requests to clarify, but not change, part of the spec label May 19, 2024
@handrews handrews added this to the v3.0.4 milestone May 19, 2024
@handrews handrews requested a review from a team May 19, 2024 15:19
miqui
miqui previously approved these changes May 21, 2024
Copy link
Contributor

@miqui miqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pre-approve this. I deem the language here to be appropriate.

ralfhandl
ralfhandl previously approved these changes May 22, 2024
Clarifies that there can be multiple complete OpenAPI documents,
only one of which is an entry OpenAPI document.
@handrews handrews dismissed stale reviews from ralfhandl and miqui via f3343c1 May 22, 2024 16:16
@handrews handrews marked this pull request as ready for review May 22, 2024 16:16
@handrews
Copy link
Member Author

Conflicts merged - it needs at least one re-approval to merge because pushing the conflict resolution unset both existing approvals. There is no change to the actual change here- there was just another change to different words on the same line.

@ralfhandl ralfhandl requested a review from miqui May 23, 2024 07:13
@miqui miqui merged commit 8acc31d into OAI:v3.0.4-dev May 23, 2024
1 check passed
lornajane added a commit that referenced this pull request May 23, 2024
Clarify entry/complete document terminology (3.1.1 port of #3820)
@handrews handrews deleted the entry-again-304 branch May 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification requests to clarify, but not change, part of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants