Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket Notifications Refactor #12180

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Socket Notifications Refactor #12180

wants to merge 1 commit into from

Conversation

julianlam
Copy link
Member

No description provided.

@julianlam
refactor(socket.io): deprecate SocketNotifs.get and SocketNotifs.getC…
b08259e 
…ount in favour of api.notifications.list and api.notifications.getCount, respectively
@nodebb-misty
Copy link
Contributor

💡 Friendly Note

This pull request was made against the develop branch, which is reserved for commits destined for a minor or major release.If your commits simply fixes a bug, please rebase this PR against the master instead.

  • patch releases — bug fixes only
  • minor releases — new features, enhancements, and bug fixes
  • major releases — breaking changes, including all of the above

Thanks!

@julianlam julianlam marked this pull request as draft November 21, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julianlam @nodebb-misty