Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename default express session key from express.sid to nodebb.sid #12089

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

julianlam
Copy link
Member

No description provided.

@julianlam julianlam added this to the 4.0.0 milestone Oct 16, 2023
@nodebb-misty
Copy link
Contributor

💡 Friendly Note

This pull request was made against the develop branch, which is reserved for commits destined for a minor or major release.If your commits simply fixes a bug, please rebase this PR against the master instead.

  • patch releases — bug fixes only
  • minor releases — new features, enhancements, and bug fixes
  • major releases — breaking changes, including all of the above

Thanks!

@julianlam
Copy link
Member Author

Technically not a breaking change, but when merged, would automatically log everyone out unless sessionKey is set in config.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants