Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite3 support #11524

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Sqlite3 support #11524

wants to merge 4 commits into from

Conversation

chung-leong
Copy link

Enables the use of SQLite3 for storage. Meant for forums with low traffic running on limited hardware (1 CPU server). Uses better-sqlite3.

@nodebb-misty
Copy link
Contributor

💡 Friendly Note

This pull request was made against the develop branch, which is reserved for commits destined for a minor or major release.If your commits simply fixes a bug, please rebase this PR against the master instead.

  • patch releases — bug fixes only
  • minor releases — new features, enhancements, and bug fixes
  • major releases — breaking changes, including all of the above

Thanks!

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@bil-ash
Copy link

bil-ash commented Dec 15, 2023

Any idea why this has not been merged?
It is actually great for small forums with very limited users and hardware (where $100 for 50000 views is not required)

@nhlpl
Copy link

nhlpl commented Dec 21, 2023

They were busy releasing major NodeBB versions. And maybe some worries about future maintenance. Let's hope SQLite support will be merged soon. For me it looks good.

@bil-ash
Copy link

bil-ash commented Dec 22, 2023 •
edited

@julianlam @barisusakli Please merge this

bil-ash
bil-ash approved these changes Dec 23, 2023
View reviewed changes
Copy link

@bil-ash bil-ash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bil-ash
Copy link

bil-ash commented Dec 23, 2023

Sorry, approved the changes by mistake

@tedyoung
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil-ash bil-ash bil-ash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chung-leong @nodebb-misty @CLAassistant @bil-ash @nhlpl @tedyoung