Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autoinstall plugins on setup #11485

Merged
merged 2 commits into from Apr 28, 2023
Merged

Conversation

oplik0
Copy link
Contributor

@oplik0 oplik0 commented Apr 14, 2023

related to #10766, #10767 and #10036

Adds a plugins:autoinstall config option that installs all active, but not yet installed plugins on setup.

Intended to be primarily used with plugins:active, but it doesn't require it.

Note that it will fail setup if a plugin can't be installed - this is intended (but if you believe it's better to fail quietly I can change that).

Additionally there is a small plugins:active specific change to the admin page allowing for installing/uninstalling active plugins set via config without them disappearing from the active page (primarily to handle the case of not using autoinstall - since the admin will then be able to simply install everything active from the ACP)

@oplik0
Copy link
Contributor Author

oplik0 commented Apr 17, 2023

@julianlam should this also be rebased to develop?

@julianlam
Copy link
Member

Yes please 👍

@oplik0 oplik0 changed the base branch from master to develop April 27, 2023 22:25
@oplik0
Copy link
Contributor Author

oplik0 commented Apr 27, 2023

Done, sorry for the delay :)

@julianlam julianlam merged commit 2bfdd76 into NodeBB:develop Apr 28, 2023
15 checks passed
@julianlam julianlam added this to the 3.1.0 milestone Apr 28, 2023
@julianlam julianlam self-requested a review April 28, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants