Add plugin.js support #10763
Open
Add plugin.js support #10763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
This is fine... Signed-off-by: steve <29133953+stevefan1999-personal@users.noreply.github.com>
|
I am not opposed to defining plugin configuration information this way 👍 |
|
@barisusakli @psychobunny what you guys think? |
barisusakli
reviewed
Aug 12, 2023
barisusakli
reviewed
Aug 14, 2023
| configPath = path.join(paths.nodeModules, plugin, 'plugin.js'); | ||
| } | ||
| // eslint-disable-next-line no-await-in-loop | ||
| if (!await file.exists(configPath)) { |
There was a problem hiding this comment.
This if block should move into the above if block, otherwise if there is a plugin.json we are doing 2x file.exists(configPath) checks with the same configPath value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it would be better to use a full blown script for plugin manifest because we can use it to resolve some complicated stuff and future type stubs for code safety*. This practice is basically everywhere. SWC, ESLint, Mocha, Jest all allows such use.
For my own sake, this also added a slightly good benefit of lexicographically sorting the fields thanks to ESLint. My OCD hits when I see the fields not being sorted from A to Z.
*: if you used a TypeScript transpiler, that is what most people should start doing.
Missing