chore: making the scheduler db not rely on env vars #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
May 17, 2024
| if (!url || !schema) { | ||
| throw new Error('Missing required database url and schema for monitor worker'); | ||
| } | ||
| const dbClient = new DatabaseClient({ url, schema, poolMax: 10 }); |
There was a problem hiding this comment.
the worker thread doesn't share anything with the main thread and only serializable object can be messaged between them so we are creating another db client for the worker thread. Right now the worker is only expiring tasks but when we add support for recurring tasks the worker will be responsible for all state transitions not trigger by an event
TBonnin
force-pushed
the
tbonnin/scheduler-db-params
branch
3 times, most recently
from
90b247a
to
2e6575f
Compare
khaliqgant
approved these changes
May 21, 2024
bodinsamuel
approved these changes
May 21, 2024
configuring the scheduler, which is a independant library, with env vars make it harder to understand where things are being configured and how. We ran into issues with the records package regarding default env vars value and behavior if/when not configured. With this commit the db url and schema are passed into the scheduler package and we don't have a global db object within the package. The `Tasks` function are now all taking `db` as their first parameter, this has the nice side effect to make it possible to run them in a transaction if needed.
TBonnin
force-pushed
the
tbonnin/scheduler-db-params
branch
from
2e6575f
to
81fa54c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
configuring the scheduler, which is a independant library, with env vars make it harder to understand where things are being configured and how. We ran into issues with the records package regarding default env vars value and behavior if/when not configured. With this commit the db url and schema are passed into the scheduler package and we don't have a global db object within the package. The
Tasksfunction are now all takingdbas their first parameter, this has the nice side effect to make it possible to run them in a transaction if needed.Checklist before requesting a review (skip if just adding/editing APIs & templates)