Bifacial option in Mermoud Lejeune module model #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2021
|
@allenlawrence94 Thank you so much, this is great! I will be merging this in for our upcoming release! We super appreciate the contribution. |
|
Awesome! Thanks janine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #241
I cherry-picked the commit that exposes a bifacial option from @caseyzak24's PR #314, added a test, and fixed a couple bugs.
More detail on the bugs:
nanwhen front-side irradiance was 0. It seemssunupshould prevent the pv model from running when irradiance is 0, but it still happens occasionally (in the new test case it occurs in 112 shoulder hours in the year). Is this okay?