Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci Runners for Mac Intel & Windows #1162

Merged
merged 37 commits into from May 9, 2024
Merged

Ci Runners for Mac Intel & Windows #1162

merged 37 commits into from May 9, 2024

Conversation

dguittet
Copy link
Collaborator

@dguittet dguittet commented May 8, 2024

Add Github actions CI runners for Macosx Intel and Windows

@dguittet dguittet requested review from brtietz and sjanzou May 8, 2024 15:02
@dguittet dguittet mentioned this pull request May 8, 2024
Open
5 tasks
brtietz
brtietz approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

sjanzou
sjanzou approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, it looks like Windows was the biggest PITA!

@dguittet dguittet merged commit 5e4136d into patch May 9, 2024
8 checks passed
@dguittet dguittet deleted the ci_runners branch May 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brtietz brtietz brtietz approved these changes

@sjanzou sjanzou sjanzou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dguittet @brtietz @sjanzou