New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to address SAM issue 1477 for host developer only #1141
base: patch
Are you sure you want to change the base?
Conversation
Test file Test with IBI with no basis reduction Test with IBI with federal and state basis reduction Test with federal and state taxable IBI and federal and state basis reduction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment NREL/SAM#1477
The ITC amounts now have the behavior that I'd expect, but I'm a little concerned that IBI isn't showing up in purchase of property: Would some of the test processes from #1047 be relevant here? |
I think much more testing is in order here and for all of the financial markets. I am leaning towards moving issue NREL/SAM#1477 and NREL/SAM#1722 to patch 2 - any objections? |
@sjanzou Agreed. The milestones for those issues have been changed to patch 2 |
I think we should review in detail before proceeding with host developer and other markets.
See NREL/SAM#1722