Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign detailed schedules using the lookup #1166

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

joseph-robertson
Copy link
Contributor

Pull Request Description

Adds ResStockArguments arguments:

  • heating_setpoint_schedule
  • cooling_setpoint_schedule
  • water_heater_setpoint_schedule
  • battery_schedule

Update ResStockArguments measure to populate schedules_filepaths based on the contents of these new arguments. Update an arbitrary Battery option to assign battery_schedule. Only the testing project samples battery options.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@joseph-robertson
Copy link
Contributor Author

This PR has identified a bug in how OS-HPXML calculates detailed utility bills for homes with modeled batteries. The fix is here: NREL/OpenStudio-HPXML#1554.

@shorowit
Copy link
Contributor

Seems unlikely that you could ever use a single schedule across all buildings in the housing stock. Maybe it should be like detailed utility rates, where you can point to files based on a specified parameter?

@joseph-robertson
Copy link
Contributor Author

joseph-robertson commented Nov 15, 2023

Seems unlikely that you could ever use a single schedule across all buildings in the housing stock. Maybe it should be like detailed utility rates, where you can point to files based on a specified parameter?

Yeah, I thought about that too. I think the idea in using the options_lookup, is that the schedule could differ by option for a given parameter. That's essentially the same approach used for detailed utility rates, except that the mapping is pulled out into its own lookup so as to support multiple scenarios.

@shorowit
Copy link
Contributor

True, I guess you can always create a new TSV parameter for use in options_lookup to ensure you apply the desired schedule to a given building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants