fix(pint_units): Fixed BaseQuantity to allow quantities multiplications
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions List of changes: - Removed `__new__` from BaseQuantity - Added `ureg.check` to default units. This will check if the unit is compatible, but will not check the input value. - Added testing for BaseQuantity class and units. Issue #24
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 95.75% 95.44% -0.31%
==========================================
Files 24 25 +1
Lines 2074 2131 +57
==========================================
+ Hits 1986 2034 +48
- Misses 88 97 +9 ☔ View full report in Codecov by Sentry. |
…that are not classes.
daniel-thom
reviewed
May 20, 2024
KapilDuwadi
approved these changes
May 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
…ions (#25) List of changes: - Removed `__new__` from BaseQuantity which was causing the problem - Renamed `__compatible_unit__` to `__base_unit__` - Added `ureg.check` to default units. This will check if the unit is compatible, but will not check the input value. - Added testing for BaseQuantity class and units. - Added a serialization property so that we can call `component.model_dump(mode="json")` when using pint.Quantities, Closes #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemetantion questions
active_power? Or shall I define them as classes with the caveat that it can not be in one liner.List of changes:
__new__from BaseQuantityBaseQuantityto perform pint validation on pydanticCloses #24