Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop MIT Yaw Loss model in V4 #797

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Feb 8, 2024

Develop MIT Yaw Loss model in V4

This draft PR/branch is meant to collaboratively develop the MIT yaw loss model into the v4 framework.

This pull request should take over for PR #638 as this works much better in the v4 framework than in v3.

Related issue

Issue #624
Pull request #638

@paulf81
Copy link
Collaborator Author

paulf81 commented Feb 8, 2024

@misi9170 , was hoping to get a quick check from you that this all looks like a reasonable starting point

@paulf81 paulf81 self-assigned this Feb 8, 2024
@paulf81 paulf81 added enhancement An improvement of an existing feature v4 Focus of FLORIS v4 labels Feb 8, 2024
@paulf81 paulf81 added this to the v4.0 milestone Feb 8, 2024
@misi9170
Copy link
Collaborator

misi9170 commented Feb 9, 2024

@misi9170 , was hoping to get a quick check from you that this all looks like a reasonable starting point

Looks good! I made a minor change to the example and then added a placeholder for testing the new operation model. The tests are currently based on the CosineLossTurbine, so may start failing as the actual MITLossTurbine code is implemented. That's fine; the tests should then be updated to reflect the actual expected behavior. I'm happy to help with that.

@paulf81
Copy link
Collaborator Author

paulf81 commented Feb 9, 2024

@misi9170 , was hoping to get a quick check from you that this all looks like a reasonable starting point

Looks good! I made a minor change to the example and then added a placeholder for testing the new operation model. The tests are currently based on the CosineLossTurbine, so may start failing as the actual MITLossTurbine code is implemented. That's fine; the tests should then be updated to reflect the actual expected behavior. I'm happy to help with that.

Sounds great, thank you!

@misi9170 misi9170 removed the v4 Focus of FLORIS v4 label Apr 7, 2024
@rafmudaf rafmudaf deleted the branch NREL:develop April 12, 2024 15:26
@rafmudaf rafmudaf closed this Apr 12, 2024
@rafmudaf rafmudaf reopened this Apr 12, 2024
@misi9170 misi9170 changed the base branch from v4 to develop April 12, 2024 20:31
@rafmudaf rafmudaf removed this from the v4.0 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants