-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use existing simulation yaw angles in planar calculations instead of switching to zero yaw angles #449
base: develop
Are you sure you want to change the base?
Conversation
This change is causing an error in example 00:
I'm not sure the best way to resolve this (whether it is to fix the test or the code), but will mark as a draft to indicate this is not ready to be merged. |
Thoughts from discussion:
|
Interesting thoughts @rafmudaf. How about assigning the turbine yaw angles in the
Cons are that this can be API breaking and increases the size of |
…aw_angles is None
@pjireland I rebased your commit onto the |
Thanks for the update, @rafmudaf! |
Feature or improvement description
calculate_horizontal_plane
,calculate_cross_plane
, andcalculate_y_plane
previously used zero yaw angles if called withyaw_angles=None
. This PR changes the behavior to use the existing yaw angles fromself.floris.farm.yaw_angles
instead.Related issue, if one exists
#448
Impacted areas of the software
floris.tools.floris_interface.py
Test results, if applicable
Example visualization before change:
Example visualization after change:
Unit test results: