Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disaggregated heat load inputs and outputs + Process heat load #583

Merged
merged 31 commits into from May 10, 2024

Conversation

zolanaj
Copy link
Collaborator

@zolanaj zolanaj commented May 7, 2024

Please check if the PR fulfills these requirements

  • CHANGELOG.md is updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Disaggregated heating loads are now available by heating load type: DomesticHotWaterLoad and SpaceHeatingLoad are now available separately
  • New heating load ProcessHeatLoad included
  • New heat-load-specific outputs for heating technologies added

Does this PR introduce a breaking change?

(What changes might users need to make in their application due to this PR?)
None known, but the new I/O requires linkage to v. 0.46.1 of REopt.jl

Other information:

@zolanaj zolanaj mentioned this pull request May 7, 2024
@zolanaj zolanaj changed the title DNMY: Disaggregated heat load inputs and outputs + Process heat load Disaggregated heat load inputs and outputs + Process heat load May 9, 2024
@Bill-Becker
Copy link
Collaborator

@zolanaj just making sure this won't affect any existing behavior when using the default can_serve_... and that the outputs for HeatingLoad should all be unchanged as well. I'm making sure about this for the web tool interfacing with the API.

@zolanaj zolanaj requested a review from adfarth May 10, 2024 02:33
@zolanaj
Copy link
Collaborator Author

zolanaj commented May 10, 2024

@zolanaj just making sure this won't affect any existing behavior when using the default can_serve_... and that the outputs for HeatingLoad should all be unchanged as well. I'm making sure about this for the web tool interfacing with the API.

Confirmed, the defaults for CHP, ExistingBoiler, HotThermalStorage, Boiler, and SteamTurbine can all serve both DHW and space heating by default, which is consistent with the notion that all techs serve all heating loads. The exception is GHP which already had the field can_serve_dhw set to False as default.

HeatingLoad outputs for DHW and SpaceHeating are unchanged. There are new outputs within HeatingLoad related to process heat, but only if included (otherwise it's blank). Will that work or should those be suppressed somehow?

@@ -6420,6 +6693,12 @@ class AbsorptionChillerInputs(BaseModel, models.Model):
'hot_water'
))

HEATING_LOAD_INPUT = models.TextChoices('HEATING_LOAD_INPUT', (
'DomesitHotWater',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this spelling in abf56a1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and the changelog update!

@@ -6193,6 +6371,55 @@ def clean(self):
if self.addressable_load_fraction == None:
self.addressable_load_fraction = list([1.0]) # should not convert to timeseries, in case it is to be used with monthly_mmbtu or annual_mmbtu

class ProcessHeatLoadInputs(BaseModel, models.Model):
# DHW
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "#DHW" here intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not! Updated it here - d7d6652

uuid = "d36ad4e8-d74a-4f7a-ace1-eaea049febf6"
version = "0.45.0"
version = "0.46.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note to update this to the 46.1 eventually

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder! Addressed here: ae8fcea

Copy link
Collaborator

@adfarth adfarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one very minor comment :)

@Bill-Becker
Copy link
Collaborator

@zolanaj thanks for confirming, that should work.

@zolanaj zolanaj merged commit a8d82ff into develop May 10, 2024
1 check passed
@adfarth adfarth mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants