Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin regexp_parser to 2.9.0 #5204

Merged
merged 4 commits into from
May 17, 2024
Merged

Pin regexp_parser to 2.9.0 #5204

merged 4 commits into from
May 17, 2024

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 16, 2024

Pull request overview

uses https://github.com/NREL/openstudio-gems/releases/tag/v3.8.0-RC3-2

$ Products/openstudio -e "require 'rubocop/rake_task'; require 'stringio'; RuboCop::RakeTask.new(:rubocop) do |t| t.options = ['--autocorrect', '--format', 'simple', '--only', 'Lint/SelfAssignment'] end; Rake.application[:rubocop].invoke"
Running RuboCop...

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec added component - CLI Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Ruby bindings labels May 16, 2024
@jmarrec jmarrec self-assigned this May 16, 2024
@wenyikuang
Copy link
Collaborator

wenyikuang commented May 16, 2024

We could merge it once the arm64_linux os-gems get ready.

@jmarrec
Copy link
Collaborator Author

jmarrec commented May 17, 2024

I've just wiped the CI build dirs so that it's clean and rules out issues that could explain why we have bundle tests failing right now (including on ubuntu 20.04, while it passes on my machine...)

@jmarrec
Copy link
Collaborator Author

jmarrec commented May 17, 2024

3903: Source locally installed gems is ignoring #<Bundler::StubSpecification name=strscan version=3.1.0 platform=ruby> because it is missing extensions

@jmarrec jmarrec mentioned this pull request May 17, 2024
19 tasks
@kbenne kbenne merged commit 032597f into develop May 17, 2024
4 of 6 checks passed
@kbenne kbenne deleted the pin_regexp_parser branch May 17, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - CLI component - Ruby bindings Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoking rubocop fails in 3.8.0-RC3 due to regexp parser error
4 participants